Change in ovirt-engine[master]: webadmin: Fix handling of empty network name

Code Review gerrit at ovirt.org
Tue Jun 27 14:52:32 UTC 2017


>From Alexander Wels <awels at redhat.com>:

Alexander Wels has submitted this change and it was merged.

Change subject: webadmin: Fix handling of empty network name
......................................................................


webadmin: Fix handling of empty network name

If the user manually changes the name of the default vNIC profile,
it is not synchronised to the network name anymore.

This synchronization can be broken, by synchronize the name of the
default vNIC profile name to an empty network name, which is
represented as 'null' value in the entity.

This changes fixes the behavior by not stopping the synchronization,
if the default vNIC profile name is 'null'.

Change-Id: I78fa9b356e51f49e833d12cbd3bdc36799099938
Bug-Url: https://bugzilla.redhat.com/1459003
Bug-Url: https://bugzilla.redhat.com/1463568
Signed-off-by: Dominik Holler <dholler at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Dominik Holler: Verified
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Vojtech Szocs: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/78363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I78fa9b356e51f49e833d12cbd3bdc36799099938
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list