Change in ovirt-engine[master]: webadmin: replace blank white screen with 'Loading' spinner

Code Review gerrit at ovirt.org
Thu Jun 29 21:58:51 UTC 2017


>From Greg Sheremeta <gshereme at redhat.com>:

Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/78800 )

Change subject: webadmin: replace blank white screen with 'Loading' spinner
......................................................................


webadmin: replace blank white screen with 'Loading' spinner

Previously, after logging in, there was a 5 to 10
second white screen pause while the initial GWT
JS script downloaded, JIT compiled, and rendered the
GWT UI.

This patch adds a PatternFly loading spinner to the GWT
host page, which is the root page of the webadmin
(i.e. the white screen == the host page).

Now, while GWT JS selector script is doing its work,
this 'loading page' is shown.

We still want to reduce the size of the initial GWT
download. This is a good intermediate fix.

Change-Id: Ie5ef8377a1e555316b94ddf6d6310408e11c5a01
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/MainSectionPresenter.java
2 files changed, 62 insertions(+), 0 deletions(-)

Approvals:
  Greg Sheremeta: Verified; Passed CI tests
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78800
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5ef8377a1e555316b94ddf6d6310408e11c5a01
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list