Change in ovirt-engine[master]: webadmin: Improve TypeLiteral bindings in PresenterModule

[Code Review]

>From Alexander Wels <awels at redhat.com>:

Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/78520 )

Change subject: webadmin: Improve TypeLiteral bindings in PresenterModule
......................................................................


webadmin: Improve TypeLiteral bindings in PresenterModule

Added bindSingletonPresenterWidget() overload accepting TypeLiteral
parameters. This reduces error potential, compared to the existing
2x bind() methods.

SearchPanelView<M> now extends SearchPanelPresenterWidget.ViewDef<M>
as it should. This was a bug made visible by using above overload.

Change-Id: I3b05146e1a05e7d2c86a02e3a3d78d9921e9bb45
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/SearchPanelView.java
2 files changed, 72 insertions(+), 34 deletions(-)

Approvals:
  Alexander Wels: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/78520
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3b05146e1a05e7d2c86a02e3a3d78d9921e9bb45
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>