Change in ovirt-engine[ovirt-engine-4.1.1.z]: webadmin: Fix ClassCastException when removing template's disk

Code Review gerrit at ovirt.org
Wed Mar 1 09:05:51 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Fix ClassCastException when removing template's disk
......................................................................


webadmin: Fix ClassCastException when removing template's disk

When attempting to remove a template's disk from the Storage
sub-tab the operation fails with a ClassCastException.

Fixed by using a list of DiskModel instead of a StorageDomainModel
since we are selecting a disk and operating on it.

Another ClassCastException occurred on line 175 since
result.getState() returns a TemplateStorageListModel and not
a ConfirmationModel.

Change-Id: I81f8d145d4e0ec79f635b1e84589a53fda91f538
Bug-Url: https://bugzilla.redhat.com/1420265
Signed-off-by: Benny Zlotnik <bzlotnik at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateStorageListModel.java
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/73304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I81f8d145d4e0ec79f635b1e84589a53fda91f538
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list