Change in ovirt-engine[master]: core: Inline TagsDirector#tagDao

Code Review gerrit at ovirt.org
Wed Mar 1 11:52:01 UTC 2017


>From Martin Betak <mbetak at redhat.com>:

Martin Betak has submitted this change and it was merged.

Change subject: core: Inline TagsDirector#tagDao
......................................................................


core: Inline TagsDirector#tagDao

The getTagDao() method is a useless getter that only existed so it could
be stubbed away in the test. Since the test now injects a mock dao,
there's no need for it, and it can safely be removed.

Change-Id: I4346fb8a4c38e8de2f4c2d4ff649525afbeb2a31
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java
1 file changed, 1 insertion(+), 5 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Martin Betak: Looks good to me, but someone else must approve
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/73112
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4346fb8a4c38e8de2f4c2d4ff649525afbeb2a31
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list