Change in ovirt-engine-sdk-ruby[sdk_4.1]: Check that URL has been provided

Code Review gerrit at ovirt.org
Thu Mar 2 18:40:11 UTC 2017


>From Juan Hernandez <juan.hernandez at redhat.com>:

Juan Hernandez has submitted this change and it was merged.

Change subject: Check that URL has been provided
......................................................................


Check that URL has been provided

Currently the SDK doesn't check that the 'url' parameter has been
provided. As a unexpected errors happen later, when using the
connection, which are difficult to interpret. To avoid that this patch
changes the 'Connection' class so that it raises an exception is the
'url' parameter isn't provided.

Change-Id: I927c4097e718fe7b63e73c72bbff3c960b6387ac
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit 772749b455a7601d4587e715d6a43f8a4cfbf73f)
---
M sdk/lib/ovirtsdk4/connection.rb
M sdk/spec/connection_create_spec.rb
2 files changed, 13 insertions(+), 0 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/73477
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I927c4097e718fe7b63e73c72bbff3c960b6387ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list