Change in ovirt-engine-sdk[master]: Read correctly attributes with enum values

Code Review gerrit at ovirt.org
Fri Mar 3 11:49:50 UTC 2017


>From Ondra Machacek <omachace at redhat.com>:

Ondra Machacek has submitted this change and it was merged.

Change subject: Read correctly attributes with enum values
......................................................................


Read correctly attributes with enum values

A recent patch introduced a mechanism to ignore incorrect values of
enum types. That patch also introduced a regresion for attributes of
enum types that have a name different to their type name. For
example, the 'vm.migration.auto_converge' attribute is of type
'InheritableBoolean', not of type 'AutoConverge' as assumed by the
code generator. This patch fixes that issue.

Change-Id: I7e8df50f4dd59881238346f7b9ce06dd2a653546
Signed-off-by: Ondra Machacek <omachace at redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java
A sdk/tests/test_vm_reader.py
2 files changed, 107 insertions(+), 1 deletion(-)

Approvals:
  Ondra Machacek: Verified; Looks good to me, approved
  Juan Hernandez: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/73514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7e8df50f4dd59881238346f7b9ce06dd2a653546
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list