Change in gerrit-admin[master]: Handle ext tracker 'None' status in set_modified hook

Code Review gerrit at ovirt.org
Sun Mar 12 08:29:04 UTC 2017


>From Eyal Edri <eedri at redhat.com>:

Eyal Edri has submitted this change and it was merged.

Change subject: Handle ext tracker 'None' status in set_modified hook
......................................................................


Handle ext tracker 'None' status in set_modified hook

The hook checks the external trackers (patches) of the bug,
and according to the external tracker 'status' field it checks if the patch is
open ('POST') or closed ('MERGED').
The problem is when the user adds manual patch by adding the patch number,
the 'status' parameter remain 'None'.

Adding some code to query gerrit (if the 'status' == 'None') to get the
real status of the patch.

Change-Id: I56d37381e7af07a431b69d44b695667ad6a7f9ad
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1235
Signed-off-by: Shlomi Ben-David <sbendavi at redhat.com>
---
M hooks/custom_hooks/set_modified
1 file changed, 78 insertions(+), 32 deletions(-)

Approvals:
  Shlomo Ben David: Verified
  Eyal Edri: Looks good to me, approved
  Gil Shinar: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/73695
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I56d37381e7af07a431b69d44b695667ad6a7f9ad
Gerrit-PatchSet: 3
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi at redhat.com>


More information about the Engine-commits mailing list