Change in gerrit-admin[master]: Added more logic to set_modified hook

Code Review gerrit at ovirt.org
Tue Mar 14 16:01:00 UTC 2017


>From Eyal Edri <eedri at redhat.com>:

Eyal Edri has submitted this change and it was merged.

Change subject: Added more logic to set_modified hook
......................................................................


Added more logic to set_modified hook

Adding more logic to check that the bug milestone is equal to the patch branch,
if it's not equal it will check that the branch (for that milestone)
doesn't exist and only then it will set the bug status to MODIFIED.

Example 1:
patch branch: ovirt-engine-4.1
bug milestone: ovirt-4.1.1 (branch doesn't exist)
result: OK ==> will change the bug status to MODIFIED

Example 2:
patch branch: ovirt-engine-4.1
bug milestone: ovirt-4.1.1 (branch exist)
result: WARN ==> bug status won't be changed to MODIFIED
(detected a newer branch 'ovirt-engine-4.1.1.z' that matches the milestone)

Change-Id: I5b6808f51bd2286089753b0afd7238c1869b4008
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1238
Signed-off-by: Shlomi Ben-David <sbendavi at redhat.com>
---
M hooks/custom_hooks/set_modified
1 file changed, 104 insertions(+), 20 deletions(-)

Approvals:
  Shlomo Ben David: Verified
  Eyal Edri: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/73767
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5b6808f51bd2286089753b0afd7238c1869b4008
Gerrit-PatchSet: 2
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi at redhat.com>


More information about the Engine-commits mailing list