Change in ovirt-engine[master]: core: Clarify meaning of memory fields in VDS and VdsStatistics

Code Review gerrit at ovirt.org
Tue Mar 14 19:33:33 UTC 2017


>From Martin Sivák <msivak at redhat.com>:

Martin Sivák has submitted this change and it was merged.

Change subject: core: Clarify meaning of memory fields in VDS and VdsStatistics
......................................................................


core: Clarify meaning of memory fields in VDS and VdsStatistics

The memAvailable field returned by VDSM is an approximation of how
much RAM would be available for starting a new VM if all running
VMs used all their allocated memory. But the overhead calculation
is more complicated than that and the engine also has overcommit
rules and so the memAvailable field is not really useful anymore.

Also document the units for related swap fields.

Change-Id: Ib58aecbd9036730f24e38e797f8bc6133c4b7bc7
Signed-off-by: Martin Sivak <msivak at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java
2 files changed, 21 insertions(+), 0 deletions(-)

Approvals:
  Martin Sivák: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/73870
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib58aecbd9036730f24e38e797f8bc6133c4b7bc7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list