Change in ovirt-engine[master]: webadmin, userportal: GWT/P upgrade, part 4

[Code Review]

>From Vojtech Szocs <vszocs at redhat.com>:

Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin,userportal: GWT/P upgrade, part 4
......................................................................


webadmin,userportal: GWT/P upgrade, part 4

- remove <build><finalName> in gwt-aop POM
  * this JAR isn't reflected into GWT webapp's WEB-INF/lib directory,
    therefore no need for the ovirt prefix (build-only dependency)

- remove gwt-aop as gwt-maven-plugin dependency, add it as explicit
  dependency of WebAdmin and UserPortal modules

- GWT RPC related changes
  * remove unused RpcRemoteOracleServlet
  * in GwtCommon.gwt.xml, no <inherits> for "com.google.gwt.rpc.RPC"
    since the "com.google.gwt.user.User" module already inherits it
    as "com.google.gwt.user.RemoteService" (RPC module got renamed)

- fix compile errors due to changes in core GWT classes

- don't break <gwt-plugin.extraJvmArgs> into multiple lines, since
  the "\" character doesn't seem to work and messes up with Maven

- update gwt-maven-plugin configuration
  * failOnError=true replaces strict=true
  * remove redundant classpath exclude (no effect on GWT compile)

Change-Id: I105645ffb90ee672c9e57355183a314345dd80b0
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
D frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/RpcRemoteOracleServlet.java
M frontend/webadmin/modules/gwt-aop/pom.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractPopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
9 files changed, 32 insertions(+), 194 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Greg Sheremeta: Looks good to me, approved
  Vojtech Szocs: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/73552
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I105645ffb90ee672c9e57355183a314345dd80b0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>