Change in ovirt-engine[master]: webadmin, userportal: GWT/P upgrade, part 2

[Code Review]

>From Vojtech Szocs <vszocs at redhat.com>:

Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin,userportal: GWT/P upgrade, part 2
......................................................................


webadmin,userportal: GWT/P upgrade, part 2

- extract AOP stuff (DontPrune aspect) into separate gwt-aop module
  * gwt-extension now contains custom field serializers (for GWT RPC)
    and custom (super-sourced) Java classes, a.k.a "uioverrides"
  * gwt-aop now contains AOP tweaks for GWT compiler
  * this effectively fixes the "gwt-extension's META-INF/aop.xml gets
    applied twice during GWT compilation" problem

- remove <gwt-maven-plugin.workingRefresh.version>
  * before: 2.6.1 for GWT compile + 2.4.0 (workingRefresh) for debug
  * after: use 2.8.0 for both GWT compile and debug
  * the issue was that gwt-maven-plugin didn't pick up file changes,
    if we face this issue again (with gwt-maven-plugin:2.8.0), we'll
    need to solve it in a way that does not involve downgrading the
    gwt-maven-plugin version

- use <superDevMode>false</superDevMode> for GWT debug
  * this is because GWT 2.7+ makes Super Dev Mode the default debug
    method, while deprecating the Classic (Java IDE based) Dev Mode
  * for now, don't disrupt the existing GWT debug workflow
    - Classic Dev Mode remains the main debug method
    - Super Dev Mode remains the alternative debug method

Change-Id: Ic3ae84779aa3b42aeafea2ebbaa7ebbcb1874d0c
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
A frontend/webadmin/modules/gwt-aop/pom.xml
R frontend/webadmin/modules/gwt-aop/src/main/java/org/ovirt/engine/ui/gwtaop/AspectJLogHandler.java
R frontend/webadmin/modules/gwt-aop/src/main/java/org/ovirt/engine/ui/gwtaop/DontPrune.java
R frontend/webadmin/modules/gwt-aop/src/main/java/org/ovirt/engine/ui/gwtaop/JavaLoggingConfig.java
R frontend/webadmin/modules/gwt-aop/src/main/resources/META-INF/aop.xml
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M pom.xml
11 files changed, 51 insertions(+), 61 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Greg Sheremeta: Looks good to me, approved
  Vojtech Szocs: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/73550
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3ae84779aa3b42aeafea2ebbaa7ebbcb1874d0c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>