Change in ovirt-engine[master]: core: Introducing CreateAllTemplateDisksCommand

Code Review gerrit at ovirt.org
Thu Mar 16 09:33:24 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: Introducing CreateAllTemplateDisksCommand
......................................................................


core: Introducing CreateAllTemplateDisksCommand

Adding CreateAllTemplateDisksCommand that creates all disks needed for
creating a template. This command is called from AddVmTemplateCommand
instead of calling CreateImageTemplateCommand and
CloneSingleCinderDiskCommand directly.

AddVmTemplateFromSnapshotCommand runs
CreateAllTemplateDisksFromSnapshotCommand for the same purpose.

CreateAllTemplateDisksCommand incorporates callback that is needed to
poll the child commands that create disk images. The callback in
AddVmTemplateCommand orchestrates the process of template creation,
including post-processing of template disk images, which will be added
in the next patches.

Change-Id: I6fc7e46df640a5ec0c0c7bc0e3f512e16d6969ae
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/CreateAllTemplateDisksCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/CreateAllTemplateDisksFromSnapshotCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllTemplateDisksParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
6 files changed, 402 insertions(+), 149 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/69323
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6fc7e46df640a5ec0c0c7bc0e3f512e16d6969ae
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list