Change in ovirt-engine[master]: core: Use set for disk ids fetched from VM's OVF.

Code Review gerrit at ovirt.org
Mon Mar 20 12:06:16 UTC 2017


>From Maor Lipchuk <mlipchuk at redhat.com>:

Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Use set for disk ids fetched from VM's OVF.
......................................................................


core: Use set for disk ids fetched from VM's OVF.

Since VM OVF might contain several nodes of the same disk in case of a
snapshot we should use set instead of list since the use of this method
is only used for disk ids.

Change-Id: I710b5fdfb126c7ea75838c5f98f1a8e707211356
Bug-Url: https://bugzilla.redhat.com/1430865
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/OvfUtilsTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java
2 files changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Maor Lipchuk: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/74280
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I710b5fdfb126c7ea75838c5f98f1a8e707211356
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list