Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: CloneImageGroupVolumesStructure - determineSourceImage...

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: CloneImageGroupVolumesStructure - determineSourceImageGroup()
......................................................................


core: CloneImageGroupVolumesStructure - determineSourceImageGroup()

This patch changes the determineSourceImageGroup() method -

1. removes unneeded equality check by reference which was actually never true,
if it was true - the returned id is wrong and therefore it's unneeded.

2. reduces an sql query, if both the parent and the template image
equals Guid.Empty a db query was performed, blank image with Guid.Empty
was returned and that was the image group id - we can save that query.

Change-Id: I362132b991e73ae2192b3271040dbb71e028adba
Bug-Url: https://bugzilla.redhat.com/1429170
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/74375
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I362132b991e73ae2192b3271040dbb71e028adba
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>