Change in ovirt-engine[ovirt-engine-4.1]: restapi: Avoid place holders that aren't replaced

Code Review gerrit at ovirt.org
Thu Mar 23 08:45:38 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: restapi: Avoid place holders that aren't replaced
......................................................................


restapi: Avoid place holders that aren't replaced

The API documentation uses place holders like {engine-name} and
{product-name} that should be replaced by the corresponding values
during the build process. But this doesn't work correctly because the
HTML generator isn't invoked with the right parameters. That can be
fixed adding the right parameters, or changing the build process so that
it uses the HTML code already included in the artifacts of the model
project. That has the same effect and reduces a bit the time needed for
the build. Note that this mechanism is already used for
'/ovirt-engine/apidoc', this patch just uses the same mechanism for
'/ovirt-engine/api/model', which is now deprecated.

Change-Id: I2f42a0f5d832f7247151cd721dc47c0d2112d3c3
Bug-Url: https://bugzilla.redhat.com/1434056
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit 6aa40f0b474b353e5d0f7283c90b665301c5c3d0)
---
M backend/manager/modules/restapi/interface/definition/pom.xml
M pom.xml
2 files changed, 26 insertions(+), 41 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Juan Hernandez: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/74519
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2f42a0f5d832f7247151cd721dc47c0d2112d3c3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list