Change in ovirt-engine[master]: core: Fix update of video devices in UpdateVmTemplateCommand

Code Review gerrit at ovirt.org
Thu Mar 23 11:23:28 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: Fix update of video devices in UpdateVmTemplateCommand
......................................................................


core: Fix update of video devices in UpdateVmTemplateCommand

The proper VmDeviceUtils#updateVideoDevices was only called from
UpdateVmCommand and UpdateVmTemplateCommand contained only a snippet of code
that covered just a small fraction of all the possible flows. Replaced this
handling in UpdateVmTemplateCommand with proper call to
VmDeviceUtils#updateVideoDevices.

Change-Id: Id4c139248fdfa0774f883d9737bcbc2c627d2cff
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1434161
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
2 files changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Jakub Niedermertl: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Martin Betak: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/74528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4c139248fdfa0774f883d9737bcbc2c627d2cff
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list