Change in ovirt-engine[master]: build: Don't run checkstyle on generated-sources

Code Review gerrit at ovirt.org
Mon Mar 27 10:33:19 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: build: Don't run checkstyle on generated-sources
......................................................................


build: Don't run checkstyle on generated-sources

Suppressing the checks on generated-sources is the wrong approach, as
it still runs all the checks, and then just suppresses their outcome.
This patch takes a more efficient approach, and just excludes them
a priori.

Change-Id: I42943047ce69ed7b505ac1656c42a8acef95dce8
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml
M build-tools-root/checkstyles/src/main/resources/checkstyle.xml
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Freddy Rolland: Looks good to me, but someone else must approve
  Greg Sheremeta: Looks good to me, but someone else must approve
  Vojtech Szocs: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/74619
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42943047ce69ed7b505ac1656c42a8acef95dce8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list