Change in ovirt-engine[master]: frontend: Fix Checkstyle (NlsCheck) related issues

Code Review gerrit at ovirt.org
Mon Mar 27 21:43:15 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: frontend: Fix Checkstyle (NlsCheck) related issues
......................................................................


frontend: Fix Checkstyle (NlsCheck) related issues

- NlsCheck no longer crashes on NumberFormatException
  when the non-localized string contains "{}" (making
  the Checkstyle think it's a log message placeholder)

- when debugging GWT applications, disable NlsCheck as
  we tell build-helper-maven-plugin to add extra Java
  sources and some of them aren't meant to be checked,
  like the gwt-extension module

Change-Id: I39d9343e9e06673a1ec30c7e10241d689298770c
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NlsCheck.java
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
3 files changed, 21 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/74611
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I39d9343e9e06673a1ec30c7e10241d689298770c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list