Change in ovirt-engine[ovirt-engine-4.1]: core: fix a regression on import image as template

Code Review gerrit at ovirt.org
Thu Mar 30 07:37:00 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: fix a regression on import image as template
......................................................................


core: fix a regression on import image as template

Recent changes in the add-template flow, to support sealing of the
template, caused a regression in the flow of importing an image from
glance as a template.

Previously, the AddVmTemplate command was not async in this flow (as the
images already exist in the storage domain). Now, we create a callback
anyway which exposes a bug in the detection of whether the VM that the
template is based on exists in the database or not.

This patch provides a fix for this.

Change-Id: I3c61c28be70c1b394b94fac985ce840777035962
Bug-Url: https://bugzilla.redhat.com/1436219
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/74762
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3c61c28be70c1b394b94fac985ce840777035962
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list