Change in ovirt-engine[master]: webadmin: Fix active tab highlighting

Code Review gerrit at ovirt.org
Fri Mar 31 15:59:24 UTC 2017


>From Greg Sheremeta <gshereme at redhat.com>:

Greg Sheremeta has submitted this change and it was merged.

Change subject: webadmin: Fix active tab highlighting
......................................................................


webadmin: Fix active tab highlighting

There seems to be a GWTP bug related to legacy slot
handling, see the following discussion for details:

https://groups.google.com/forum/#!topic/gwt-platform/eDpwOubUCmE

For now, we're working around the problem by adding
the necessary call. In future, we'll modify our code
to use the new GWTP slot API.

Change-Id: Ie36566f9d87c04d1c1106339ae62e82712ffa2bf
Bug-Url: https://bugzilla.redhat.com/1434042
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/DynamicTabContainerPresenter.java
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/74719
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie36566f9d87c04d1c1106339ae62e82712ffa2bf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list