Change in ovirt-engine[master]: webadmin: Inline Linq.GlusterVolumeSnapshotConfigComparator

Code Review gerrit at ovirt.org
Fri Mar 31 18:31:33 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: Inline Linq.GlusterVolumeSnapshotConfigComparator
......................................................................


webadmin: Inline Linq.GlusterVolumeSnapshotConfigComparator

GlusterVolumeSnapshotConfigComparator is only used in one place
(GlusterClusterSnapshotConfigModel).
With Java 8's easy syntax, there's no reason to have it in Linq
instead of just have a oneliner with the same logic where it's
actually needed.

Change-Id: I35d05c73cc5173c54ce7572af7d9c43a96038a36
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterClusterSnapshotConfigModel.java
2 files changed, 2 insertions(+), 12 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/74933
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I35d05c73cc5173c54ce7572af7d9c43a96038a36
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list