Change in ovirt-engine[master]: webadmin: Inline Linq.NetworkInClusterComparator

Code Review gerrit at ovirt.org
Fri Mar 31 18:31:33 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: Inline Linq.NetworkInClusterComparator
......................................................................


webadmin: Inline Linq.NetworkInClusterComparator

NetworkInClusterComparator is only used in one place
(StorageDataCenterListModel).
With Java 8's easy syntax, there's no reason to have it in Linq
instead of just have a oneliner with the same logic where it's
actually needed.

Change-Id: I3e21ef890eda821c162331758bda4bcda367e5ff
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java
2 files changed, 6 insertions(+), 22 deletions(-)

Approvals:
  Martin Mucha: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/74939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3e21ef890eda821c162331758bda4bcda367e5ff
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list