Change in ovirt-engine[master]: engine: Reuse InsertAuditLog stored procedure

Code Review gerrit at ovirt.org
Mon May 1 21:06:35 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: engine: Reuse InsertAuditLog stored procedure
......................................................................


engine: Reuse InsertAuditLog stored procedure

The only difference in SP for saving entities to DB between externl to
internal events is a limitation we'd like to apply on message length.
The message handling can be done on the command level and we'd be able
to reuse the same stored procedure.

Change-Id: I6ab4762942fbc1a1fa8e69b076180e51188af581
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalEventCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDaoTest.java
M packaging/dbscripts/audit_log_sp.sql
4 files changed, 52 insertions(+), 174 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Roy Golan: Looks good to me, approved
  Moti Asayag: Verified



-- 
To view, visit https://gerrit.ovirt.org/76132
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ab4762942fbc1a1fa8e69b076180e51188af581
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list