Change in ovirt-engine[master]: webadmin: PoolModelBehaviorBaseTest#getBehavior return value

Code Review gerrit at ovirt.org
Wed May 3 13:48:53 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: PoolModelBehaviorBaseTest#getBehavior return value
......................................................................


webadmin: PoolModelBehaviorBaseTest#getBehavior return value

This patch changes the implementation of the
filterClusters(List<Cluster) method of the VmModelBehaviorBase
instance returned by the getBehavior() method to return an empty list
instead of null.

This is done in order to signify to static analysis tools like
Coverity that this method is expected to return a non-null value.

This patch solves Coverity CID 1374427.

Change-Id: I3f791494b1d41c60a407c24c039d0f35d278a45d
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBaseTest.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jakub Niedermertl: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/76067
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f791494b1d41c60a407c24c039d0f35d278a45d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list