Change in ovirt-engine[master]: webadmin: AbstractUserPortalListModel#finishSearch setEntity

Code Review gerrit at ovirt.org
Thu May 4 13:59:57 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: AbstractUserPortalListModel#finishSearch setEntity
......................................................................


webadmin: AbstractUserPortalListModel#finishSearch setEntity

Since UserPortalItemModel's constructor calls setEntity in its last
line, explicitly calling it in this method is redundant.

This patch cleans up the code by removing the redundant explicit
call, and also offers a slight performance improvement by raising the
related events only once instead of twice.

Change-Id: Ie4e0b0901edf88326c65d26c42605a88361a195e
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/76441
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4e0b0901edf88326c65d26c42605a88361a195e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list