Change in ovirt-engine[master]: engine: Avoid injection in AsyncTaskManager

Code Review gerrit at ovirt.org
Sun May 7 15:55:05 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: engine: Avoid injection in AsyncTaskManager
......................................................................


engine: Avoid injection in AsyncTaskManager

Since all of the data to be logged is already present at the creating of
the audit-log entity, there is no need to inject any beans to the
AuditLogableBase and it can be replaced with a leaner and more efficient
implementation of the AuditLogable.

Change-Id: I3fe02a5a595d6a8de6a4da4b6b21bc753da6117f
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Eli Mesika: Looks good to me, but someone else must approve
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Roy Golan: Looks good to me, but someone else must approve
  Moti Asayag: Verified



-- 
To view, visit https://gerrit.ovirt.org/76273
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3fe02a5a595d6a8de6a4da4b6b21bc753da6117f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list