Change in ovirt-engine[master]: engine: fix AddVdsSpmIdCommand to use correct DC id

Code Review gerrit at ovirt.org
Tue May 9 18:38:28 UTC 2017


>From Alona Kaplan <alkaplan at redhat.com>:

Alona Kaplan has submitted this change and it was merged.

Change subject: engine: fix AddVdsSpmIdCommand to use correct DC id
......................................................................


engine: fix AddVdsSpmIdCommand to use correct DC id

Before the patch, when the command is run internally, the parent
transaction is suspended (by default), so the vds object, that is
loaded in getExclusiveLocks method and is cached on the command object,
is in the state that ignores the updates that are done in the parent
transaction (command). This way when the command is run from
UpdateClusterCommand and the last has updated an initially detached
cluster to belong to a DC, that new DC id isn't reflected in the vds
object that the command loads from the DB.
The patch fixes the described problem by preventing the suspension of
the parent transaction, so when the command runs internally from another
one it would see the DB data as it was updated by the parent command.

Change-Id: I2ab4e6f1332fe785ad4a19cb8e4dead3264d7815
Signed-off-by: Yevgeny Zaspitsky <yzaspits at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Yevgeny Zaspitsky: Verified



-- 
To view, visit https://gerrit.ovirt.org/75822
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2ab4e6f1332fe785ad4a19cb8e4dead3264d7815
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list