Change in ovirt-engine[master]: core: BaseConditionFieldAutoCompleter addAll

Code Review gerrit at ovirt.org
Mon May 15 15:09:23 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: BaseConditionFieldAutoCompleter addAll
......................................................................


core: BaseConditionFieldAutoCompleter addAll

Use the optimized addAll(Collection<T>) method instead of looping
over a key set and calling add(T) on each item.
At worst, the code is just more elegant this way. At best, it may
hold some minor optimizations.

Change-Id: Ibcf15904984df8ee708e67673035e423d8b1a429
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/76813
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcf15904984df8ee708e67673035e423d8b1a429
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list