Change in ovirt-engine[ovirt-engine-4.1]: webadmin: handle VmDynamic.fqdn==null in SubTabNetworkVmView

Code Review gerrit at ovirt.org
Wed May 17 08:24:43 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: handle VmDynamic.fqdn==null in SubTabNetworkVmView
......................................................................


webadmin: handle VmDynamic.fqdn==null in SubTabNetworkVmView

In case VmDynamic.fqdn is set to null value, there is a "is null"
exception thrown by SafeHtmlString while trying to create the fqdn
tooltip in fqdnColumn.getTooltip() method.

Avoiding that by passing an empty str instead of a null value.

Change-Id: Ib27f4090bd51b15f48d37cf1dfdecbde2b5f2811
Bug-Url: https://bugzilla.redhat.com/1442697
Signed-off-by: Sharon Gratch <sgratch at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkVmView.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Sharon Gratch: Verified



-- 
To view, visit https://gerrit.ovirt.org/76914
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib27f4090bd51b15f48d37cf1dfdecbde2b5f2811
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list