Change in ovirt-engine[master]: frontend: fix ClassCastException in StorageModel

Code Review gerrit at ovirt.org
Wed May 17 13:12:29 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: frontend: fix ClassCastException in StorageModel
......................................................................


frontend: fix ClassCastException in StorageModel

StorageModel::updateDiscardAfterDelete used to set the
Discard After Delete (DAD) entity to false if it's not a block storage
domain. This caused DAD's entity changed event to be raised, which
should happen only for block domains.

This patch removes the redundant call to setEntity on DAD, as it's
already being set to false when switching back to a block domain.

Change-Id: Ie31f4e195569b2ce931f82d856e364e274825349
Bug-Url: https://bugzilla.redhat.com/1451246
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Freddy Rolland: Looks good to me, but someone else must approve
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/76931
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie31f4e195569b2ce931f82d856e364e274825349
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list