Change in ovirt-engine[master]: core: handle 'migration failure due to maintenance' logging

Code Review gerrit at ovirt.org
Wed May 17 17:45:32 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: handle 'migration failure due to maintenance' logging
......................................................................


core: handle 'migration failure due to maintenance' logging

In case a vm migration is running due to vds in
VDSStatus.PreparingForMaintenance status (i.e. vds moved to maintenance and
caused a vm migration to start), then in case the migration failed, we
need to check if there is a destination host existed or not.

Before this fix, the audit log message in case of no destination vds
left to re-run on, included an "UNKNOWN" destination vds name:
"Migration failed  while Host is in 'preparing for maintenance' state.
Consider manual intervention: stopping/migrating Vms as Host's state will not
turn to maintenance while VMs are still running on it.(VM: STAYING_ALIVE-8,
Source: dell-r210ii-13, Destination: <UNKNOWN>)"

In this patch we added a new message for omitting destination
host if none exist after re-run trials.

Change-Id: I74605aa7d37551169911e4a406dac094e65e0566
Bug-Url: https://bugzilla.redhat.com/1436397
Signed-off-by: Sharon Gratch <sgratch at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 7 insertions(+), 4 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Sharon Gratch: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/76868
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I74605aa7d37551169911e4a406dac094e65e0566
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list