Change in ovirt-engine[master]: core: one should not be able to deassign defaultRole from mg...

Code Review gerrit at ovirt.org
Thu May 18 12:37:13 UTC 2017


>From Tomas Jelinek <tjelinek at redhat.com>:

Tomas Jelinek has submitted this change and it was merged.

Change subject: core: one should not be able to deassign defaultRole from mgmt network
......................................................................


core: one should not be able to deassign defaultRole from mgmt network

In networks->cluster->ManageNetwork you can assign/deassign network
role for this single network. You should be able to assign/deassign
default route role for any network, but only assign for mgmt network,
because when you deassign default route role from network, it will be
assigned back to mgmt network, which would therefore look as
errorneous when done on mgmt network.

Change-Id: I99064854fc596ddc75663c3819d6ea9fe558d217
Bug-Url: https://bugzilla.redhat.com/1443412
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Martin Mucha: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/76978
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I99064854fc596ddc75663c3819d6ea9fe558d217
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list