Change in ovirt-engine[master]: engine: Remove spare injection in GlusterSyncJob

Code Review gerrit at ovirt.org
Thu May 18 14:02:40 UTC 2017


>From Sahina Bose <sabose at redhat.com>:

Sahina Bose has submitted this change and it was merged.

Change subject: engine: Remove spare injection in GlusterSyncJob
......................................................................


engine: Remove spare injection in GlusterSyncJob

Since all of the data to be logged is already present at the creation
of the audit-log entity, there is no need to inject any beans to the
AuditLogableBase and it can be replaced with a leaner and more
efficient implementation of the AuditLogable.

In addition, the same method to create event in gluster flows can be
reused, therefore introducing and reusing GlusterEventFactory.

Change-Id: I67e7ed9fd59c0bdf168c66ad70e8755a062ecd56
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitGlusterCommandHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterEventFactory.java
3 files changed, 28 insertions(+), 20 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Sahina Bose: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/76526
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I67e7ed9fd59c0bdf168c66ad70e8755a062ecd56
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list