Change in ovirt-engine[master]: webadmin: Fix 'X' button in global alert box

Code Review gerrit at ovirt.org
Fri May 19 19:37:51 UTC 2017


>From Vojtech Szocs <vszocs at redhat.com>:

Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin: Fix 'X' button in global alert box
......................................................................


webadmin: Fix 'X' button in global alert box

Closing the global alert box via 'X' button triggers
a runtime exception that says "This widget's parent
does not implement HasWidgets".

Fix the problem by using AlertPanel-specific override,
without modifying WidgetTooltip / AlertPanel widgets.

Change-Id: Ic64835c43dd142ca51d1aa094cb18c2bfb139c1d
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.java
1 file changed, 28 insertions(+), 9 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Vojtech Szocs: Verified



-- 
To view, visit https://gerrit.ovirt.org/77040
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic64835c43dd142ca51d1aa094cb18c2bfb139c1d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list