Change in ovirt-engine[master]: webadmin: Properly handle empty disk selection

Code Review gerrit at ovirt.org
Sun May 21 09:03:30 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: Properly handle empty disk selection
......................................................................


webadmin: Properly handle empty disk selection

Commit 0af332 that was issued to fix bug #1452790 solved the UI
freezing problem, but missed the distinction between passing an empty
list CreateAllSnapshotsFromVmParameters (no disks should be included
in the snapshot) and a null list (all the disks of the VM should be
included in the snapshot).

This patch fixes that mistake.

Change-Id: Ie69b1f2dbef9c8386c0ae8363145ec3d0c90b74c
Bug-Url: https://bugzilla.redhat.com/1452790
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/77056
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie69b1f2dbef9c8386c0ae8363145ec3d0c90b74c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list