Change in ovirt-engine[master]: core: WelcomeServletTest mocking

Code Review gerrit at ovirt.org
Mon May 22 10:43:44 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: WelcomeServletTest mocking
......................................................................


core: WelcomeServletTest mocking

VdcQueryReturnValue is a POJO with no interesting logic defined in
the common module.
As such, there's very little benefit in mocking it instead of just
returning a new instance in the test.

Besides cleaning up the code, this patch mainly lays some ground work
towards making VdcQueryReturnValue final.

Change-Id: Ia99fa3cb6b07b3b1746e50c41d688f791d840cdf
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/welcome/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java
1 file changed, 3 insertions(+), 5 deletions(-)

Approvals:
  Ravi Nori: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests
  Vojtech Szocs: Looks good to me, but someone else must approve
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/76965
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia99fa3cb6b07b3b1746e50c41d688f791d840cdf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list