Change in ovirt-engine[master]: resatpi: BackendSnapshotResourceTest#testRestore mocking

Code Review gerrit at ovirt.org
Mon May 22 10:43:45 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: resatpi: BackendSnapshotResourceTest#testRestore mocking
......................................................................


resatpi: BackendSnapshotResourceTest#testRestore mocking

testRestore mocks an expectation for a JobId when performing a
snapshot restore, which just isn't correct.

This patch removes this redundant (read: wrong) mocking.

Change-Id: Ic8357880b0b2e562a0ba574b8bcecc6219716394
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResourceTest.java
1 file changed, 2 insertions(+), 10 deletions(-)

Approvals:
  Ori Liel: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests
  Moti Asayag: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/76960
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8357880b0b2e562a0ba574b8bcecc6219716394
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list