Change in ovirt-engine[ovirt-engine-4.1]: restapi: don't fail when listing vm session of non-existing ...

Code Review gerrit at ovirt.org
Wed May 24 09:03:07 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: restapi: don't fail when listing vm session of non-existing user
......................................................................


restapi: don't fail when listing vm session of non-existing user

When VM console sessions are listed and the there is session for
user which don't exist in oVirt database, we should not fail and
return 404, but we should just don't fetch additional data about
this user.

Change-Id: I293f16cb02a6ebd56872ef49b06dbd6672ae1473
Bug-Url: https://bugzilla.redhat.com/1440861
Signed-off-by: Ondra Machacek <omachace at redhat.com>
(cherry picked from commit 8d29d060132f454dfdf3fb796a953cd371efdc09)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmSessionsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmSessionsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResourceTest.java
5 files changed, 41 insertions(+), 45 deletions(-)

Approvals:
  Ondra Machacek: Verified
  Martin Peřina: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/77189
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I293f16cb02a6ebd56872ef49b06dbd6672ae1473
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list