Change in ovirt-engine[master]: packaging: setup: Allow to preview iptables changes also una...

Code Review gerrit at ovirt.org
Thu May 25 07:37:04 UTC 2017


>From Sandro Bonazzola <sbonazzo at redhat.com>:

Sandro Bonazzola has submitted this change and it was merged.

Change subject: packaging: setup: Allow to preview iptables changes also unattended
......................................................................


packaging: setup: Allow to preview iptables changes also unattended

Passing in the answerfile
OVESETUP_CONFIG/firewallChangesReview=bool:True will now output the
changes.

Change-Id: I807402ccc67b14a98c13c4c2fb10da4fdf71b5d5
Bug-Url: https://bugzilla.redhat.com/1146558
Signed-off-by: Yedidyah Bar David <didi at redhat.com>
---
M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_iptables.py
1 file changed, 34 insertions(+), 23 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Yedidyah Bar David: Verified



-- 
To view, visit https://gerrit.ovirt.org/77276
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I807402ccc67b14a98c13c4c2fb10da4fdf71b5d5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde at redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael at rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list