Change in ovirt-engine[master]: core: ProcessOvfUpdateForStoragePoolCommand - db updates

Code Review gerrit at ovirt.org
Thu May 25 10:05:58 UTC 2017


>From Liron Aravot <laravot at redhat.com>:

Liron Aravot has submitted this change and it was merged.

Change subject: core: ProcessOvfUpdateForStoragePoolCommand - db updates
......................................................................


core: ProcessOvfUpdateForStoragePoolCommand - db updates

ProcessOvfUpdateForStoragePoolCommand.performOvfUpdate() iterates over
the ovf data and updates it to the db, the max limit is for items per
update is OVF_MAX_ITEMS_PER_SQL_STATEMENT.
The lists are being initiated after the first loop, in case more than
one iteration not all the updates will be performed.
This case was never actually reached because the number of ids processed
is always lower or equals to the OVF_MAX_ITEMS_PER_SQL_STATEMENT - This
patch fixes that wrong placement of the initiation for correctness.

Change-Id: I968c9cd789a52e66a0c91d33629808e368bc29d1
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/77313
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I968c9cd789a52e66a0c91d33629808e368bc29d1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list