Change in ovirt-engine[master]: core: Add a unit test for queries constructors

Code Review gerrit at ovirt.org
Fri May 26 10:12:29 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Add a unit test for queries constructors
......................................................................


core: Add a unit test for queries constructors

Following the previous patches that streamlined the queries to all
have two-argument constructors, this patch extracts the common
functionality of testing constructors from CommandCtorsTest and
introduces a similar test to make sure all the queries are defined
correctly.

Change-Id: Ia69475e7256e591a088c0656a961984237195a01
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandCtorsTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CtorsTestBase.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueriesCtorsTest.java
3 files changed, 235 insertions(+), 155 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/77117
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia69475e7256e591a088c0656a961984237195a01
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list