Change in ovirt-engine[master]: core: change LSM lock scope to execution

Code Review gerrit at ovirt.org
Mon May 29 13:40:40 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: change LSM lock scope to execution
......................................................................


core: change LSM lock scope to execution

Since the memory lock on the disk is not needed for
the entire command and only needed until the DB lock
is acquired, the scope can be changed to execution.

Having the lock in the Command scope also causes a
race condition if an operation runs after LSM tasks
are done but the engine lock was not released yet.

Change-Id: Ic2edf9ac086ed3b647e68379f3507443308e3a0c
Bug-Url: https://bugzilla.redhat.com/1456504
Signed-off-by: Benny Zlotnik <bzlotnik at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Benny Zlotnik: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/77504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2edf9ac086ed3b647e68379f3507443308e3a0c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list