Change in ovirt-engine[master]: core: empty string should not be considered as valid ipv4 ad...

Code Review gerrit at ovirt.org
Tue May 30 10:33:02 UTC 2017


>From Martin Peřina <mperina at redhat.com>:

Martin Peřina has submitted this change and it was merged.

Change subject: core: empty string should not be considered as valid ipv4 address
......................................................................


core: empty string should not be considered as valid ipv4 address

Change-Id: I923b157e4ad7c93420092f41b63c08a9525e7de9
Bug-Url: https://bugzilla.redhat.com/1160667
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IPAddressPatternTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/Ipv4ConstraintTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/Ipv4OrIpv6ConstraintTest.java
4 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Martin Mucha: Verified
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/70346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I923b157e4ad7c93420092f41b63c08a9525e7de9
Gerrit-PatchSet: 30
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list