Change in ovirt-engine[master]: webadmin: passthrough and port mirroring must always be disa...

Code Review gerrit at ovirt.org
Wed May 31 14:38:56 UTC 2017


>From Greg Sheremeta <gshereme at redhat.com>:

Greg Sheremeta has submitted this change and it was merged.

Change subject: webadmin: passthrough and port mirroring must always be disabled for external networks
......................................................................


webadmin: passthrough and port mirroring must always be disabled for external networks

Change-Id: I5797f5beedc30f82a6b163bb9ffaab57ecb719e7
Signed-off-by: Marcin Mirecki <mmirecki at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1390930
Bug-Url: https://bugzilla.redhat.com/1394555
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
3 files changed, 14 insertions(+), 6 deletions(-)

Approvals:
  Marcin Mirecki: Verified
  Greg Sheremeta: Looks good to me, approved; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/77399
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5797f5beedc30f82a6b163bb9ffaab57ecb719e7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list