[Engine-devel] signed-off-by in commit message

Oved Ourfalli ovedo at redhat.com
Mon Apr 30 11:50:30 UTC 2012


----- Original Message -----
> From: "Moti Asayag" <masayag at redhat.com>
> To: infra at ovirt.org, engine-devel at ovirt.org
> Sent: Monday, April 30, 2012 2:44:16 PM
> Subject: Re: [Engine-devel] signed-off-by in commit message
> 
> On 04/24/2012 06:11 PM, Itamar Heim wrote:
> > per previous thread by Ryan Harper[1] and ovirt meeting today,
> > starting
> > may 1st gerrit policy will change for all projects to require
> > signed-off-by in the commit message.
> > 
> 
> You may add the "Signed-off-by" field by adding "-s" flag to the "git
> commit" command, either by specifying it for each commit command or
> by
> setting it as an alias in the .git/config
> 
> e.g. for ovirt-engine:
> 
> [alias]
>     cm=commit -s -F config/engine-commit-template.txt -e
> 

Or add the following lines to the commit message git hook:

SO=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p')
grep -qs "^$SO" "$1" || echo "$SO" >> "$1"


> > vdsm and ovirt-node already have this active
> > 
> > Thanks,
> >    Itamar
> > 
> > for more details:
> > http://kerneltrap.org/files/Jeremy/DCO.txt
> > 
> > [1]http://www.mail-archive.com/arch@ovirt.org/msg00273.html
> > _______________________________________________
> > Infra mailing list
> > Infra at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 



More information about the Engine-devel mailing list