[Engine-devel] Fwd: Problem in REST API handling/displaying of logical networks

Mike Kolesnik mkolesni at redhat.com
Thu Jul 5 08:13:09 UTC 2012


----- Original Message -----
> On 05/07/12 10:24, Miki Kenneth wrote:
> > 
> > 
> > ----- Original Message -----
> >>
> >>
> >> ----- Original Message -----
> >>> From: "Itamar Heim" <iheim at redhat.com>
> >>> To: "Simon Grinberg" <simon at redhat.com>
> >>> Cc: "engine-devel" <engine-devel at ovirt.org>
> >>> Sent: Wednesday, July 4, 2012 7:38:46 PM
> >>> Subject: Re: [Engine-devel] Fwd: Problem in REST API
> >>> handling/displaying of logical networks
> >>>
> >>> On 07/04/2012 07:27 PM, Simon Grinberg wrote:
> >>>>
> >>>>
> >>>>
> >>>> Actually the API has the same concept as you suggest for storage
> >>>> domains.
> >>>> At the top level you don't have a status field, but under data
> >>>> center level, where it's valid then you get the status property.
> >>>>
> >>>> Same should go for networks.
> >>>> The status property should be added only where it's valid, in
> >>>> this
> >>>> case the cluster level sub-collection
> >>>
> >>> so sounds like we want to declare these properties deprecated to
> >>> be
> >>> able
> >>> to remove them in a future version?
> >>
> >> I guess so,
> >> The question is, are there other location where the status
> >> property
> >> (or any other property) exists at an irrelevant level. Unless we
> >> want to go into the effort of mapping them all now we probably
> >> need
> >> to define a concept and anything not complying to that is a bug
> >> that
> >> is allowed to be fixed without considering it as breaking the API.
> >>
> >> Thoughts?
> >>
> > +1
> > I agree that this is a bug and I DO suggest we  go into the effort
> > of reviewing the other objects as well.
> > This is too major to just fix this one, and wait until we bump into
> > another one...
> 
> Mike i see there a general consensus that this is a bug and the top
> level entity should be a DC network.
> Can you please open a bug / update the existing bug to reflect that.

OK then I will review the relevant bug(s) and update as needed.

Thank you all for the feedback!

Thanks,
Mike

> 
> Thanks, Livnat
> 
> 
> 
> > Any suggestions of how to do that?
> 
> 
> 



More information about the Engine-devel mailing list