[Engine-patches] Change in ovirt-engine[master]: core: run once - boot order param is not sent for CD-ROM de...

yzaslavs at redhat.com yzaslavs at redhat.com
Wed Apr 4 05:49:03 EDT 2012


Yair Zaslavsky has posted comments on this change.

Change subject: core: run once -  boot order param is not sent for CD-ROM device
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 337:                     Object o = struct.getItem(VdsProperties.SpecParams);
is it possible for specParams not to be a map?
If so - what is our error handling?
If it's not possible, maybe we can simply cast directly to the map?

--
To view, visit http://gerrit.ovirt.org/3308
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09cbd13278247e079bfb9cc1f032bd03e84cd43e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>


More information about the Engine-patches mailing list