[Engine-patches] Change in ovirt-engine[master]: Packaging: changed the way engine-cleanup removes DB (#78217...

[oschreib at redhat.com]

Ofer Schreiber has posted comments on this change.

Change subject: Packaging: changed the way engine-cleanup removes DB (#782176)
......................................................................


Patch Set 1: Fails

(3 inline comments)

....................................................
File packaging/fedora/setup/engine-cleanup.py
Line 231:         cmd = ["/usr/bin/psql", "-U", basedefs.DB_ADMIN, "-c", clearQuery]
Please use CONSTANT instead of /usr/bin/psql

Line 232:         output, rc = utils.execCmd(cmd, None, True, MSG_ERROR_CLEAR_DB_CONNECTIONS, [])
Please drop the [ ]

Line 233:         if (rc != 0):
No need for this rc check

--
To view, visit http://gerrit.ovirt.org/1407
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76a9f61ab8092156c1ad9a8b7772fbe4a6796ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>