[Engine-patches] Change in ovirt-engine[master]: engine: Add audit log messages to CRUD commands.

[ofrenkel at redhat.com]

Omer Frenkel has posted comments on this change.

Change subject: engine: Add audit log messages to CRUD commands.
......................................................................


Patch Set 1: (4 inline comments)

....................................................
File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java
Line 66:         setQuotaId((quotaParameter.getId().equals(Guid.Empty)) ? Guid.NewGuid() : quotaParameter.getId());
is there a validation on the parameters class for quota not to be null? if not, expect NPE here, as this code is called before canDoAction

Line 84:         return getSucceeded() ? AuditLogType.USER_ADD_QUOTA : AuditLogType.USER_FAILED_ADD_QUOTA;
in case of failure the quota name is not initialized, so the message will not display correctly

....................................................
File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java
Line 53:           return getSucceeded() ? AuditLogType.USER_DELETE_QUOTA : AuditLogType.USER_FAILED_DELETE_QUOTA;
same here, quota name hasn't been set (this time for success, for failure i'd expect quota id to be set)

....................................................
File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java
Line 82:           return getSucceeded() ? AuditLogType.USER_UPDATE_QUOTA : AuditLogType.USER_FAILED_UPDATE_QUOTA;
same same, here, setting quota id would be enough for both cases

--
To view, visit http://gerrit.ovirt.org/1747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I677aab915c3aba11f1e895db9ad6a6c8cf77b9a1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>